Skip to content

Use different CSS comment style for IE11 support #28750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Aug 21, 2017
Merged

Use different CSS comment style for IE11 support #28750

PVince81 merged 1 commit into from
Aug 21, 2017

Conversation

@lordelix
Copy link
Contributor

@lordelix lordelix commented Aug 21, 2017

Description

Replace // Comment style with /* Comment */ in head.css to support IE11

Related Issue

Fixes #28687

How Has This Been Tested?

Visual test in IE11 Windows 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lordelix lordelix added Type:Bug design p2-high Escalation, on top of current planning, release blocker labels Aug 21, 2017
@lordelix lordelix added this to the development milestone Aug 21, 2017
@lordelix lordelix requested a review from PVince81 August 21, 2017 09:23
PVince81
PVince81 approved these changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, IE11...

👍

@PVince81 PVince81 merged commit 9bc980f into master Aug 21, 2017
@PVince81 PVince81 deleted the fx_fix_css-comment_syntax branch August 21, 2017 09:48
@PVince81
Copy link
Contributor

PVince81 commented Aug 21, 2017

@felixheidecke please backport

@lordelix lordelix mentioned this pull request Aug 21, 2017
Merged
9 tasks
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

design p2-high Escalation, on top of current planning, release blocker status/STALE Type:Bug

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

Win8.1 IE11 app menu title wraps

5 participants

@lordelix @PVince81 @DeepDiver1975 @ownclouders