Skip to content

Make Backbone PROPPATCH work with options.wait mode #28767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Aug 23, 2017
Merged

Make Backbone PROPPATCH work with options.wait mode #28767

PVince81 merged 1 commit into from
Aug 23, 2017

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Aug 22, 2017

Description

In options.wait mode, no model.changes are available as they haven't
been set yet. So in this mode we simply get all properties and send
these with PROPPATCH.

Related Issue

Fixes owncloud/customgroups#87

Motivation and Context

Better compatibility with backbone options.

How Has This Been Tested?

Manual testing with customgroups ticket and JS unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 added this to the development milestone Aug 22, 2017
@PVince81 PVince81 self-assigned this Aug 22, 2017
@PVince81 PVince81 mentioned this pull request Aug 22, 2017
Closed
@PVince81 PVince81 force-pushed the backbone-proppatch-waitmode branch from f810792 to 2b6fa66 Compare August 22, 2017 09:55
jvillafanez
jvillafanez reviewed Aug 22, 2017
View reviewed changes
core/js/oc-backbone-webdav.js Outdated
Copy link
Member

@jvillafanez jvillafanez Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me wonder if this has ever worked... Does this link with the davSync method below? If so, any reason to move the JSON.stringify up here?

Copy link
Contributor Author

@PVince81 PVince81 Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some custom calls (ex: comments app) where it does a plain POST with JSON on the collection. Later on we decided that we didn't want POST any more with Webdav so we're now using other methods. The reason I moved this down is because the stringification is only needed for this one code path.

Copy link
Member

@jvillafanez jvillafanez Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fair enough.

@jvillafanez
Copy link
Member

jvillafanez commented Aug 22, 2017

Need to check the failing tests.

@phil-davis
Copy link
Contributor

phil-davis commented Aug 22, 2017

At the moment:
/home/travis/build/owncloud/core/tests/ui/features/files/renameFiles.feature:23
fails on every Travis job that runs it.
Waiting on #28749 to be merged, which should get master back to Travis-CI passing.

@PVince81 PVince81 force-pushed the backbone-proppatch-waitmode branch from 2b6fa66 to 29554a4 Compare August 22, 2017 13:31
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 22, 2017

rebased. now that the other fix is in I expect all will pass

Make Backbone PROPPATCH work with options.wait mode
f819148 
In options.wait mode, no model.changes are available as they haven't
been set yet. So in this mode we simply get all properties and send
these with PROPPATCH.
@PVince81 PVince81 force-pushed the backbone-proppatch-waitmode branch from 29554a4 to f819148 Compare August 23, 2017 09:42
@PVince81 PVince81 merged commit 7957015 into master Aug 23, 2017
@PVince81 PVince81 deleted the backbone-proppatch-waitmode branch August 23, 2017 17:13
@PVince81 PVince81 mentioned this pull request Aug 24, 2017
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 24, 2017

stable10: #28791

@PVince81 PVince81 mentioned this pull request Aug 29, 2017
Closed
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 29, 2017

Regression: #28826

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@VicDeo VicDeo Awaiting requested review from VicDeo

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels

4 - To release status/STALE

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

Renaming of customgroups using web ui is not possible.

5 participants

@PVince81 @jvillafanez @phil-davis @ownclouders