Skip to content

Conversation

@pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Aug 23, 2017

You might want to change ('occ upgrade') to this. Should also be fine if you keep it as it is :)

@pmaier1 pmaier1 added the p3-medium Normal priority label Aug 23, 2017
@pmaier1 pmaier1 added this to the development milestone Aug 23, 2017
@pmaier1 pmaier1 self-assigned this Aug 23, 2017
@pmaier1 pmaier1 requested a review from DeepDiver1975 August 23, 2017 08:07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for white labling reasons owncloud has to be replaced with a variable - or you simply remove it.
this -> your

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'This' changed to 'your'
  • 'ownCloud' removed

@DeepDiver1975
Copy link
Member

@tomneedham please review the english strings - thx

p($l->t('Your instance possibly hosts many users and files. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).'));
} else {
p($l->t('Please use the command line updater because automatic updating is disabled in the config.php.'));
p($l->t('Automatic updating was disabled in config.php. To upgrade your instance, please use the command line updater (occ upgrade).'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic updating is disabled in config.php. To upgrade your instance, please use the command line updater (occ upgrade)

<div class="infogroup">
<?php if ($_['tooBig']) {
p($l->t('Please use the command line updater because you have a big instance.'));
p($l->t('Your instance possibly hosts many users and files. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your instance may host many files and/or users. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).

@pmaier1
Copy link
Contributor Author

pmaier1 commented Aug 28, 2017

Thanks for review @tomneedham. Incorporated the requested changes.

@PVince81 PVince81 merged commit 36169e9 into master Aug 29, 2017
@PVince81 PVince81 deleted the pmaier1-patch-1 branch August 29, 2017 08:13
@PVince81
Copy link
Contributor

stable10: #28828

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants