-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make admin feedback easier understandable #28775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
core/templates/update.use-cli.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for white labling reasons owncloud has to be replaced with a variable - or you simply remove it.
this -> your
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 'This' changed to 'your'
- 'ownCloud' removed
551bf6b to
ad94e17
Compare
|
@tomneedham please review the english strings - thx |
core/templates/update.use-cli.php
Outdated
| p($l->t('Your instance possibly hosts many users and files. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).')); | ||
| } else { | ||
| p($l->t('Please use the command line updater because automatic updating is disabled in the config.php.')); | ||
| p($l->t('Automatic updating was disabled in config.php. To upgrade your instance, please use the command line updater (occ upgrade).')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic updating is disabled in config.php. To upgrade your instance, please use the command line updater (occ upgrade)
core/templates/update.use-cli.php
Outdated
| <div class="infogroup"> | ||
| <?php if ($_['tooBig']) { | ||
| p($l->t('Please use the command line updater because you have a big instance.')); | ||
| p($l->t('Your instance possibly hosts many users and files. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your instance may host many files and/or users. To ensure a smooth upgrade process, please use the command line updater (occ upgrade).
|
Thanks for review @tomneedham. Incorporated the requested changes. |
|
stable10: #28828 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
You might want to change ('occ upgrade') to this. Should also be fine if you keep it as it is :)