Add exact search term hits to sharee response

[tomneedham]

Description

If you setup your instance to not allow user enumeration, but try to search for a user by one of their configured search terms, we should count this as an exact match.

Motivation and Context

If you have multiple email addresses, these can be configured as search terms with the LDAP app and this PR allows you to find other users using these email addresses (terms) as exact matches when enumeration is disabled.

How Has This Been Tested?

Locally with LDAP server + PHPUnit test

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Working on improved testing for the mo...

[PVince81]

👍 makes sense, indeed the search terms were missing in that condition.

Please check the test failure in "OCA\Files_Sharing\Tests\API\ShareesTest.testGetUserWithSearchAttributes"

[PVince81]

16:13:52 1) OCA\Files_Sharing\Tests\API\ShareesTest::testGetUserWithSearchAttributes
16:13:52 Failed asserting that two arrays are equal.
16:13:52 --- Expected
16:13:52 +++ Actual
16:13:52 @@ @@
16:13:52  Array (
16:13:52 -    0 => Mock_IUser_60b22220 Object (...)
16:13:52  )
16:13:52 
16:13:52 /var/lib/jenkins/workspace/owncloud-core_core_PR-28818-HIRUNODPUCROLXW6MREEYKRWHEEXAPCS2RJ7PHMKKBHJKA7VPTHA/apps/files_sharing/tests/API/ShareesTest.php:1829

[PVince81]

please backport

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.