Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Don't assume that data is a JS object. If it's a string, let it pass as is.

Related Issue

Fixes #28826

Motivation and Context

How Has This Been Tested?

Test with ticket steps.
Unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor

See comments in:
#28826 (comment)
#28826 (comment)

this fixes the issue as I saw it both in the webUI and in the firewall tests

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine and fixes the symptoms that I can see and test

@PVince81
Copy link
Contributor Author

stable10: #28837

@phil-davis phil-davis merged commit 7f1e2cb into master Aug 29, 2017
@phil-davis phil-davis deleted the fix-oc-backbone-webdav-report branch August 29, 2017 16:25
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raised exceptions about REPORT operation when opening comments

4 participants