Skip to content

Conversation

@phisch
Copy link
Contributor

@phisch phisch commented Sep 6, 2017

Description

Recently the templateeditor (https://github.com/owncloud/templateeditor) stopped working because its dependencies could not be resolved correctly. Apparently it had access to services defined in Server before, and now it only has access to its application container DIContainer which should be the correct behavior.

Added IThemeService to the public API to solve this issue.

Related Issue

owncloud/templateeditor#52

How Has This Been Tested?

Debugged the DI-container to see how it autowires it's dependencies and tested with owncloud/templateeditor#52

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phisch phisch added this to the development milestone Sep 6, 2017
@phisch phisch self-assigned this Sep 6, 2017
@phisch phisch requested a review from PVince81 September 6, 2017 13:42
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 strange, I thought we already added that server service ?

@phisch
Copy link
Contributor Author

phisch commented Sep 6, 2017

It was in Server but not in DIContainer, the first is for OC internal dependencies, the latter for app dependencies.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants