Skip to content

don't assume the theme directory exists #28998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Sep 14, 2017
Merged

don't assume the theme directory exists #28998

PVince81 merged 1 commit into from
Sep 14, 2017

Conversation

@phisch
Copy link
Contributor

@phisch phisch commented Sep 13, 2017

Description

Since the theme directory in the owncloud root was deleted, both ThemeService and the command maintenance:mimetype:update-js should not assume that this directory exists. This did produce some error logs, and the command was not executable without this directory.

Related Issue

#28966

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phisch phisch self-assigned this Sep 13, 2017
@phisch phisch added this to the development milestone Sep 13, 2017
@phisch phisch mentioned this pull request Sep 13, 2017
Merged
@phisch phisch removed the request for review from michaelstingl September 13, 2017 13:41
PVince81
PVince81 approved these changes Sep 13, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks safe

@PVince81
Copy link
Contributor

PVince81 commented Sep 13, 2017

please backport for 10.0.3, safe enough...

@PVince81 PVince81 merged commit 5034a91 into master Sep 14, 2017
@PVince81 PVince81 deleted the no-theme-directory-fix branch September 14, 2017 08:41
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phisch phisch

Labels

3 - To Review status/STALE

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@phisch @PVince81 @DeepDiver1975 @ownclouders