Fix folder upload race condition #29393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29393 +/- ##
=========================================
Coverage 60.51% 60.51%
Complexity 17193 17193
=========================================
Files 1031 1031
Lines 57288 57288
=========================================
Hits 34667 34667
Misses 22621 22621Continue to review full report at Codecov.
|
SergioBertolinSG
approved these changes
Oct 31, 2017
Contributor
SergioBertolinSG
left a comment
SergioBertolinSG
left a comment
There was a problem hiding this comment.
Works 👍
Fixes #28844
Contributor
Author
|
When uploading the same folder twice, sometimes a race condition is triggered where some of the first uploaded items finish faster and trigger the "end of transfer" event even though there are further items to upload. This fix prevents the end of transfer event to clear the list of uploads so it can continue.
PVince81
force-pushed
the
fix-folder-upload
branch
from
8329f9d to
ab5e20d
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When uploading the same folder twice, sometimes a race condition is
triggered where some of the first uploaded items finish faster and
trigger the "end of transfer" event even though there are further items
to upload.
This fix prevents the end of transfer event to clear the list of uploads
so it can continue.
Related Issue
Fixes #28844
Motivation and Context
How Has This Been Tested?
Manual testing, see ticket.
Screenshots (if appropriate):
Types of changes
Checklist: