Skip to content

Fix for when account not found during sync #30367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 1 commit into from
Feb 7, 2018
Merged

Fix for when account not found during sync #30367

DeepDiver1975 merged 1 commit into from
Feb 7, 2018

Conversation

@tomneedham
Copy link
Contributor

@tomneedham tomneedham commented Feb 5, 2018

@tomneedham tomneedham added this to the development milestone Feb 5, 2018
@tomneedham tomneedham self-assigned this Feb 5, 2018
@tomneedham tomneedham requested a review from butonic February 5, 2018 12:38
This was referenced Feb 5, 2018
Merged
Closed
DeepDiver1975
DeepDiver1975 requested changes Feb 5, 2018
View reviewed changes
lib/private/User/SyncService.php Outdated
$this->mapper->update($a);
} catch(DoesNotExistException $ex) {
$this->createNewAccount($backendClass, $uid);
$a = $this->createNewAccount($backendClass, $uid);
Copy link
Member

@DeepDiver1975 DeepDiver1975 Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this was not detected by the regular CI process - I assume this is missing unit tests

Copy link
Contributor

@phil-davis phil-davis Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression looks like it happened here:
https://github.com/owncloud/core/pull/29669/files#diff-37958be4e01e8baeb127a59409e1a593L114

Copy link
Contributor Author

@tomneedham tomneedham Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - looking at tests for this

@codecov
Copy link

codecov bot commented Feb 5, 2018 •
edited
Loading

Codecov Report

Merging #30367 into master will decrease coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30367      +/-   ##
============================================
- Coverage     60.84%   60.67%   -0.17%     
  Complexity    18549    18549              
============================================
  Files          1092     1092              
  Lines         61280    61280              
============================================
- Hits          37286    37182     -104     
- Misses        23994    24098     +104
Impacted Files Coverage Δ Complexity Δ
lib/private/User/SyncService.php 70.8% <50%> (+12.94%) 55 <0> (ø) ⬇️
lib/private/Repair/Collation.php 0% <0%> (-82.5%) 12% <0%> (ø)
lib/private/Repair/InnoDB.php 0% <0%> (-78.95%) 6% <0%> (ø)
...ilder/ExpressionBuilder/MySqlExpressionBuilder.php 0% <0%> (-62.5%) 3% <0%> (ø)
lib/private/DB/MySQLMigrator.php 0% <0%> (-57.7%) 7% <0%> (ø)
lib/private/DB/AdapterMySQL.php 0% <0%> (-50%) 4% <0%> (ø)
lib/private/DB/Adapter.php 61.72% <0%> (-20.99%) 25% <0%> (ø)
lib/private/DB/ConnectionFactory.php 60.52% <0%> (-14.48%) 21% <0%> (ø)
lib/private/DB/MDB2SchemaWriter.php 86.45% <0%> (-6.25%) 34% <0%> (ø)
...private/DB/MySqlSchemaColumnDefinitionListener.php 0% <0%> (-5.41%) 46% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1a4e1...41e72e0. Read the comment docs.

@tomneedham
Copy link
Contributor Author

tomneedham commented Feb 6, 2018

Added a test to run through the sync service at least once.

@individual-it
Copy link
Member

individual-it commented Feb 7, 2018

restarted drone, now passed

@DeepDiver1975 DeepDiver1975 merged commit b7787b9 into master Feb 7, 2018
@DeepDiver1975 DeepDiver1975 deleted the fix-sync branch February 7, 2018 07:47
@individual-it individual-it mentioned this pull request Feb 7, 2018
Merged
@butonic butonic mentioned this pull request Mar 15, 2018
Merged
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@phil-davis phil-davis phil-davis left review comments

@DeepDiver1975 DeepDiver1975 DeepDiver1975 requested changes

@butonic butonic Awaiting requested review from butonic

Assignees

@tomneedham tomneedham

Labels

3 - To Review

Projects

None yet

Milestone

10.0.8

Development

Successfully merging this pull request may close these issues.

5 participants

@tomneedham @individual-it @DeepDiver1975 @phil-davis