Test unlock on exception during scanning

[DeepDiver1975]

Description

In case of an exception during scanning the lock is not released

Related Issue

detected while working on #28043

How Has This Been Tested?

• unit tests added

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #30580 into master will decrease coverage by 44.85%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #30580       +/-   ##
=============================================
- Coverage     61.61%   16.76%   -44.86%     
+ Complexity    18507      808    -17699     
=============================================
  Files          1090       48     -1042     
  Lines         61112     3001    -58111     
=============================================
- Hits          37653      503    -37150     
+ Misses        23459     2498    -20961

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	6.06% <0%> (-82.76%)	163% <0%> (ø)
lib/private/Preview/Postscript.php
lib/public/Share.php
lib/private/Setup/PostgreSQL.php
lib/private/Files/Storage/Wrapper/DirMask.php
apps/files_trashbin/lib/Command/ExpireTrash.php
...ivate/IntegrityCheck/Helpers/EnvironmentHelper.php
...b/private/Authentication/TwoFactorAuth/Manager.php
settings/templates/users/part.createuser.php
core/Migrations/Version20171026130750.php
... and 1032 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d0f2f...fac3b8f. Read the comment docs.

[mmattel]

Q: is this related? #30505 (./occ files:scan user_name errores with file locked - and exits)

[DeepDiver1975]

Q: is this related? #30505 (./occ files:scan user_name errores with file locked - and exits)

if you are stuck with locks after the exception -> yes

[DeepDiver1975]

Tests proof the stray locks

[PVince81]

👍

[PVince81]

@DeepDiver1975 bad enough for backport ?

[phil-davis]

Proposed backport in #30847
Note: conflict had to be resolved related to #27532 (comment) - seemed easy to preserve some lines still in stable10 that were gone in master but that code removal never got backported to stable10

@PVince81 @DeepDiver1975

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.