Skip to content

Unskip tests for issue 29599 #31645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phil-davis wants to merge 3 commits into from
Closed

Unskip tests for issue 29599 #31645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2d953
Update sabre/dav to 3.3.0-alpha1
DeepDiver1975 Jun 5, 2018
fad2cbd
Fix BC break of Tree::getChildren()
DeepDiver1975 Jun 5, 2018
ba3ff28
Unskip tests for issue 29599
phil-davis Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dav/lib/Files/FilesHome.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function getChildren($path = null) {
if ($path === null) {
return $this->rootNode->getChildren();
}
return parent::getChildren($path);
return iterator_to_array(parent::getChildren($path));
}

public function childExists($name) {
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"deepdiver1975/TarStreamer": "v0.1.0",
"patchwork/jsqueeze": "^2.0",
"lukasreschke/id3parser": "^0.0.3",
"sabre/dav": "^3.2",
"sabre/dav": "^3.3@dev",
"deepdiver/zipstreamer": "^1.1",
"zendframework/zend-inputfilter": "^2.8",
"zendframework/zend-servicemanager": "^3.3",
Expand Down
20 changes: 8 additions & 12 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion tests/acceptance/features/apiWebdav/webdav-related-new-endpoint.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,6 @@ Feature: webdav-related-new-endpoint
| TIÄFÜ |

#this test should be integrated into the previous scenario after fixing the issue
@skip @issue-29599
Scenario: Upload a file called "0" using new chunking
Given using new DAV path
And user "user0" has been created
Expand Down
1 change: 0 additions & 1 deletion tests/acceptance/features/webUIUpload/uploadEdgecases.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ that is not academically correct but saves a lot of time

#this test should be intergrated into the previous scenario after fixing the issue
#uploading into "simple-folder" because there is a folder called "0" in the root
@skip @issue-29599
Scenario: Upload a file called "0" using chunking
Given a file with the size of "30000000" bytes and the name "0" has been created locally
When the user opens the folder "simple-folder" using the webUI
Expand Down