Fix #33630. Fix cannot set 0 as value on files_external through OCC command #33632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
requested review from
DeepDiver1975 and
PVince81
and removed request for
icewind1991
Contributor
|
@skshetry are there acceptance tests for this yet? |
Member
Author
|
@phil-davis No, I don't think we have tested occ commands for any apps that are in core. Here's the broader issue: #33051. This doesn't seem to have any unit tests also. So, I'm thinking of covering the changed code, and needs to figure that out. I'll write acceptance tests for this also. |
skshetry
force-pushed
the
fix-files_external-option-filesystemcheckchanges
branch
from
0c83378 to
ae91714
Compare
Codecov Report
@@ Coverage Diff @@
## master #33632 +/- ##
============================================
+ Coverage 64.24% 64.3% +0.05%
Complexity 18293 18293
============================================
Files 1194 1194
Lines 69132 69132
Branches 1277 1277
============================================
+ Hits 44414 44454 +40
+ Misses 24346 24306 -40
Partials 372 372
Continue to review full report at Codecov.
|
skshetry
force-pushed
the
fix-files_external-option-filesystemcheckchanges
branch
from
ae91714 to
957bd46
Compare
skshetry
force-pushed
the
fix-files_external-option-filesystemcheckchanges
branch
from
957bd46 to
04a94e6
Compare
skshetry
changed the title
PVince81
approved these changes
Nov 23, 2018
| $value = $input->getArgument('value'); | ||
| if ($value) { | ||
|
|
||
| if ($value !== null) { |
PVince81
deleted the
fix-files_external-option-filesystemcheckchanges
branch
Contributor
|
@skshetry nice find. Please backport this bugfix to stable10 |
Member
Author
|
Backport for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OCC command didn't allow us to set value 0 due to the use of
if ($value)checks. Now, This PR modifies it to check for null value only.Related Issue
filesystem_check_changesto never through occ command #33630Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: