Skip to content

Conversation

@skshetry
Copy link
Member

This commit, although a bit hacky, adds the test for the files:scan
in the Occ. The config didn't seem to have come into effect when set.
But, i noticed that the config was coming into effect when it was
force-scanned. Needs further investigation if files_external:option
is the problem or not.

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@skshetry
Copy link
Member Author

skshetry commented Nov 26, 2018

@phil-davis It seemed to me that, if you used any APIs to check for that file, it would just add the entry to it's filecache, though I cannot fully confirm this. So, I had to use the api from testing app.

EDIT: files_external:config works the same way. As per the docs, it manages backend configuration for mounts and option manages configuration for mounts. It seems confusing, but maybe it 's like backend/frontend for mounts. But, both seems to require force-scan to come into effect.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test scenario looks good.
See the comments.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. We will see what happens when drone is available some day.

@skshetry skshetry force-pushed the files-scan branch 2 times, most recently from 7b4392c to 373b4d6 Compare November 28, 2018 11:09
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #33647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33647   +/-   ##
=========================================
  Coverage     64.34%   64.34%           
  Complexity    18305    18305           
=========================================
  Files          1195     1195           
  Lines         69228    69228           
  Branches       1276     1276           
=========================================
  Hits          44548    44548           
  Misses        24308    24308           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.96% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18305 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171a41d...3105164. Read the comment docs.

@skshetry
Copy link
Member Author

@phil-davis @individual-it please review

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

This commit, although a bit hacky, adds the test for the `files:scan`
in the Occ. The config didn't seem to have come into effect when set.
But, i noticed that the config was coming into effect when it was
force-scanned. Needs further investigation if `files_external:option`
is the problem or not.
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis
Copy link
Contributor

drone and CI is all functioning now, so I asked ownclouders to rebase this.
It can be merged when CI passes.
@skshetry please make a backport

This was referenced Nov 29, 2018
@phil-davis phil-davis merged commit 2f4aa4d into master Nov 29, 2018
@phil-davis phil-davis deleted the files-scan branch November 29, 2018 05:07
@phil-davis
Copy link
Contributor

Backport stable10 #33685

@lock lock bot locked as resolved and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants