-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test files:scan #33647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test files:scan #33647
Conversation
|
@phil-davis It seemed to me that, if you used any APIs to check for that file, it would just add the entry to it's EDIT: |
phil-davis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test scenario looks good.
See the comments.
phil-davis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We will see what happens when drone is available some day.
7b4392c to
373b4d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #33647 +/- ##
=========================================
Coverage 64.34% 64.34%
Complexity 18305 18305
=========================================
Files 1195 1195
Lines 69228 69228
Branches 1276 1276
=========================================
Hits 44548 44548
Misses 24308 24308
Partials 372 372
Continue to review full report at Codecov.
|
|
@phil-davis @individual-it please review |
|
@ownclouders rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
This commit, although a bit hacky, adds the test for the `files:scan` in the Occ. The config didn't seem to have come into effect when set. But, i noticed that the config was coming into effect when it was force-scanned. Needs further investigation if `files_external:option` is the problem or not.
373b4d6 to
3105164
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
|
drone and CI is all functioning now, so I asked ownclouders to rebase this. |
|
Backport |
This commit, although a bit hacky, adds the test for the
files:scanin the Occ. The config didn't seem to have come into effect when set.
But, i noticed that the config was coming into effect when it was
force-scanned. Needs further investigation if
files_external:optionis the problem or not.
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: