Skip to content

Conversation

@skshetry
Copy link
Member

@skshetry skshetry commented Dec 5, 2018

Description

Test files:scan --group occ command

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it
Copy link
Member

@skshetry LGTM, please squash after #33738 has been merged

@skshetry skshetry force-pushed the test-file-scan-group-negative-validation branch from 7a1b22b to 7e8874c Compare December 5, 2018 07:08
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #33767 into master will decrease coverage by 15.57%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #33767       +/-   ##
=============================================
- Coverage     64.05%   48.47%   -15.58%     
=============================================
  Files          1195      109     -1086     
  Lines         69245    10498    -58747     
  Branches       1276     1276               
=============================================
- Hits          44355     5089    -39266     
+ Misses        24518     5037    -19481     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 38.67% <ø> (-26.67%) 0 <ø> (-18308)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1078 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86002e...7e8874c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #33767 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33767   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity    18309    18309           
=========================================
  Files          1195     1195           
  Lines         69255    69255           
  Branches       1276     1276           
=========================================
  Hits          44566    44566           
  Misses        24317    24317           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.66% <ø> (ø) 18309 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7fb94...272c95f. Read the comment docs.

@skshetry skshetry closed this Dec 6, 2018
@skshetry skshetry force-pushed the test-file-scan-group-negative-validation branch from 7e8874c to 6876432 Compare December 6, 2018 08:42
@skshetry skshetry reopened this Dec 6, 2018
@skshetry skshetry changed the title [BLOCKED] Test file scan group negative validation Test file scan group negative validation Dec 6, 2018
@skshetry
Copy link
Member Author

skshetry commented Dec 7, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders ownclouders force-pushed the test-file-scan-group-negative-validation branch from 355ed38 to 1c1c0ca Compare December 7, 2018 05:11
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@skshetry skshetry force-pushed the test-file-scan-group-negative-validation branch from 1c1c0ca to 272c95f Compare December 7, 2018 07:34
@phil-davis
Copy link
Contributor

@skshetry please backport

@phil-davis phil-davis merged commit 178eed3 into master Dec 10, 2018
@delete-merged-branch delete-merged-branch bot deleted the test-file-scan-group-negative-validation branch December 10, 2018 04:34
@skshetry
Copy link
Member Author

Backport for stable10 in #33834

@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants