Skip to content

Conversation

@karakayasemi
Copy link
Contributor

This reverts commit c1cf05a.

Description

Remove unused 404 events.

Related Issue

#28523 (comment)

Motivation and Context

To not spent effort for maintaining and keeping stable in the future as discussed in here: #28523 (comment)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #34835 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34835      +/-   ##
============================================
+ Coverage     65.31%   65.34%   +0.03%     
+ Complexity    18481    18478       -3     
============================================
  Files          1209     1208       -1     
  Lines         69984    69943      -41     
  Branches       1280     1280              
============================================
  Hits          45707    45707              
+ Misses        23905    23864      -41     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <0%> (+0.04%) 18478 <0> (-3) ⬇️
Impacted Files Coverage Δ Complexity Δ
ocs/v1.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/base.php 6.06% <ø> (+0.07%) 125 <0> (ø) ⬇️
remote.php 0% <ø> (ø) 0 <0> (ø) ⬇️
public.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50a569...1c7e663. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #34835 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34835      +/-   ##
============================================
+ Coverage     65.31%   65.34%   +0.03%     
+ Complexity    18481    18478       -3     
============================================
  Files          1209     1208       -1     
  Lines         69984    69943      -41     
  Branches       1280     1280              
============================================
  Hits          45707    45707              
+ Misses        23905    23864      -41     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <ø> (+0.04%) 18478 <ø> (-3) ⬇️
Impacted Files Coverage Δ Complexity Δ
ocs/v1.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/base.php 6.06% <ø> (+0.07%) 125 <0> (ø) ⬇️
remote.php 0% <ø> (ø) 0 <0> (ø) ⬇️
public.php 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50a569...1c7e663. Read the comment docs.

@karakayasemi karakayasemi requested a review from phil-davis March 19, 2019 16:47
@karakayasemi karakayasemi merged commit 30baf05 into master Mar 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-28523 branch March 19, 2019 18:36
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants