Fix file_exists call to avoid open_basedir log message

[phil-davis]

Description

PHP 7.4.21 checks open_basedir settings more exactly. Calls to file_exists can
emit log messages like "file_exists(): open_basedir restriction in effect" that
were not emitted by PHP 7.4.20.

This change fixes an incorrect file_exists check. The open_basedir message will
no longer be emitted in this case.

The PHP 7.4.21 changelog https://www.php.net/ChangeLog-7.php has a fix https://bugs.php.net/bug.php?id=76359
The code of that is https://github.com/php/php-src/pull/7024/files

But I don't see exactly how that change is causing open_basedir to start complaining now.

Related Issue

• potential fix for open_basedir errors after upgrade to PHP 7.4.21 (from 7.4.20), BUT... #39034

OP has confirmed that fix works for them: #39034 (comment)

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[JammingBen]

Looks reasonable to me as \OC_App::getAppPath($app) . '/appinfo/routes.php' never evaluated to false.

[jvillafanez]

Well, concatenating false with a string is something we should avoid anyway.

$routingFiles = [];
$appPath = \OC_App::getAppPath($app);
if ($appPath !== false) {
  if (\file_exists("{$appPath}/appinfo/routes.php")) {
    $routingFiles = [$app => $file];
  }
}

It seems better.

[phil-davis]

It seems better.

Yes, regardless of the "strange different behavior" of PHP 7.4.21 that caused this to be noticed, we should fix it anyway. The existing code was silly/wrong.

[phil-davis]

I have looked through all the calls to OC_App::getAppPath. Most of them already have checks for return value of false. I added similar checks where they were missing.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

28.6% Coverage
0.0% Duplication