Skip to content

Conversation

@DeepDiver1975
Copy link
Member

No description provided.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @icewind1991 to be a potential reviewer

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Jun 30, 2016
],
]);
\OC::$server->getEventDispatcher()->addListener(
'OCA\\Files_External::loadAdditionalBackends', function($event) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xenopathic ftp is never registered

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If files_external_ftp is loaded after files_external, the event dispatcher trigger will have already fired, so this listener won't be activated. You probably need to check if files_external is available yet, and if not, then go via the event dispatcher. This is a consequence of not knowing which order apps are loaded in, and not having the core bits of files_external in core.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ... i know what is happening. The question is how this was supposed to ever work .

@PVince81
Copy link
Contributor

Ah, damn, you already did ?

I did the same work here #9 and it does work, so maybe use my PR instead ?

@DeepDiver1975 DeepDiver1975 deleted the new-backend-registration-api branch June 20, 2017 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants