Skip to content

Conversation

@steiny2k
Copy link

@steiny2k steiny2k commented Aug 27, 2018

Fixes: #737
Equivalent to: nextcloud/gallery#464
Licence: MIT or AGPL

Description

Adds the two mime types 'image/heic' and 'image/heif' to the default list of base types that can be shown in the gallery.

In order to make use of it, the server needs to provide a sufficiently up-to-date imagemagick installation with libheif support

Features

  • renders previews for HEIF images
  • as well as shows the HEIF images in the slideshow

Screenshots or screencasts

Caveats

  • ImageMagick with libheif support needs to be installed in the server.

Tests

Test plan

  • upload a test photo from iPhon to owncloud
  • make sure the thumbnail gets rendered in the files view and the file details show a preview already
  • enter the same folder in the gallery app view
    • make sure the thumbnail is shown in the gallery app
    • make sure a slideshow displays the image in full-screen too.

Tested on

  • macOS / Safari
  • macOS / Firefox

TODO

Check list

  • Code is properly documented
  • Code is properly formatted
  • Commits have been squashed
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit fc33066 into owncloud:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants