add proper viewBox to app icon #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt to be a potential reviewer |
|
The inspection completed: No new issues |
Collaborator
|
Yup, renders correctly on FF 48.0.2 and Chromium 53.0.2785.92. Thanks for this! Merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @Mar1u5 @juliushaertl @gnarula @rullzer @jancborchardt
You can test it by looking at the Mail app entry in the apps management within Firefox. Before it was small, now it’s properly sized.
See nextcloud/server#905