Use proxy classes #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
At first look looks good, needs testing. Is it ready for quick testing ? Maybe @cdamken can patch his test setup to test this ? |
Member
Author
|
I did some testing and looks fine. It's ready for testing |
jvillafanez
force-pushed
the
always_use_proxy
branch
from
b181859 to
70684b9
Compare
Member
Author
|
rebased for automatic tests |
Contributor
|
Code looks good, as discussed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the proxy classes instead of the non-proxy ones.
Tests might need adjustment / improvement to use the proxy classes. Other than that I haven't detect any issue.