Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxc-project/oxc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 62ee689
Choose a base ref
...
head repository: oxc-project/oxc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4125aad
Choose a head ref
  • 7 commits
  • 23 files changed
  • 2 contributors

Commits on Aug 8, 2024

  1. refactor(ast_codegen): consistent import order (#4761) 

    Pure refactor. Alter import order in generated code to consistent order - `std`, external crates, `crate`, `super`.
    @overlookmotel
    overlookmotel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2dea0ca View commit details
    Browse the repository at this point in the history

  2. refactor(ast_codegen): consistent endl! position (#4762) 

    Pure refactor (style nit). Place `endl!()` macro calls in consistent position throughout codegen.
    @overlookmotel
    overlookmotel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    80046d1 View commit details
    Browse the repository at this point in the history

  3. refactor(ast_codegen): re-order imports (#4763) 

    Move imports to top of file in `generators/mod.rs`, just for consistency.
    @overlookmotel
    overlookmotel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d32fb6f View commit details
    Browse the repository at this point in the history

  4. refactor(ast_codegen): remove Generator::name and Pass::name meth… 

    …ods (#4764)

Remove `Generator::name` and `Pass::name` methods. All impls for these methods return a string identical to the struct name, so can set return value of `Runner::name` in `define_generator!` and `define_pass!` macros instead.
    @overlookmotel
    overlookmotel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7345f68 View commit details
    Browse the repository at this point in the history

  5. refactor(ast_codegen): declutter the main file. 

    same as #4741
    @rzvxa
    rzvxa committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9a94c20 View commit details
    Browse the repository at this point in the history

  6. fix(ast, ast_codegen): use generate_derive instead of visitable for… 

    … generating span derives.
    @rzvxa
    rzvxa committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    862fe61 View commit details
    Browse the repository at this point in the history

  7. fix(ast_macros): raise compile error on invalid generate_derive input. 

    It checks 2 things. 1) The input is a supported derive 2) The given identifier is the same as the fully qualified target trait.

The latter makes sure that the trait for derive is included in the scope.
    @rzvxa
    rzvxa committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4125aad View commit details
    Browse the repository at this point in the history
Loading