exportKind in ExportNamedDeclaration is always 'value'

[ArnaudBarre]

https://playground.oxc.rs/#eNo9j81qxDAMhF8l6JxDt9BLoLeSa0v7BIozWQyOZWR5u2HJu6+zITnpB+mbmQc56gj3JGqNLQlNL9J8NhdqSah7kJa4lbxE4zt1pgUtBR/t6LOThHNY5kHCMZlyzJPoTN3EIWNtKbFm6EbkEOT/F1Y0fhfLfkRfojMvVW9/T4p6e8MPK2LetxWxib8QtT8VdqaxXlGdEfL72+WjZvBZAhvGL7jAyhu+kg43TkZc8QqIyEPAnxR1mDmdarOPfvKHnpNoKqGv1renG3SQXNPvwHV9Aht6d8Q=

[camc314]

Hmm i'll need to defer to @Boshen here, as to what's the correct behaviour.

@typescript-eslint/parser shows exportnameddeclaration to have exportKind: type, but this breaks a lot of the code elsewhere in oxc that relies on the assumption that if export_kind is type, declaration isn't a TS related enum.

but perhaps we should just fix the parser, then fix the fallout elsewhere in the code

https://astexplorer.net/#/gist/805a059a30b35c5346c04571e1c3ddbe/0f45d87852872dcc6313a4b4feedd5c00a1558af

[Boshen]

Yeah this is a parser bug ... with a huge fallout 😅

[overlookmotel]

@camc314 I'm unclear if #9827 fixes this entirely, or was a step towards fixing this.

Just asking, as it sounded like there'd be huge fallout from this change, but the PR wasn't enormous. If this is fixed, please feel free to close this issue.

[camc314]

yeah this should be fixed now.

when i ran just coverage, there was a lot of snapshot changes, so i thought the fallout was going to be much bigger, but i only had to fix it in a few places

it always throws me off that graphite doesn't automatically close issues

[overlookmotel]

Thanks.

it always throws me off that graphite doesn't automatically close issues

Yeah, it's a ball-ache!