Skip to content

refactor(parser): rename var #10012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 24, 2025
Merged

refactor(parser): rename var #10012

graphite-app merged 1 commit into from
Mar 24, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 24, 2025 •
edited
Loading

Tiny refactor. Just rename a variable.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 24, 2025
@overlookmotel overlookmotel force-pushed the 03-24-refactor_parser_rename_var branch from d873d80 to 09cb88a Compare March 24, 2025 10:21
@overlookmotel overlookmotel marked this pull request as ready for review March 24, 2025 10:21
@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 24, 2025

Uncontroversial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 24, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 24, 6:22 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 24, 6:22 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 24, 6:35 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 24, 6:48 AM EDT: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10012 will not alter performance

Comparing 03-24-refactor_parser_rename_var (b93c394) with main (8cd7430)

Summary

✅ 33 untouched benchmarks

@overlookmotel
refactor(parser): rename var (#10012)
b93c394 
Tiny refactor. Just rename a variable.
@graphite-app graphite-app bot force-pushed the 03-24-refactor_parser_rename_var branch from 09cb88a to b93c394 Compare March 24, 2025 10:40
@graphite-app graphite-app bot merged commit b93c394 into main Mar 24, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 03-24-refactor_parser_rename_var branch March 24, 2025 10:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel