refactor(ast): methods for fieldless enums take self not &self + remove unnecessary matches!
#10013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Instrumentation Performance ReportMerging #10013 will not alter performanceComparing Summary
|
Member
Author
|
Uncontroversial change, and no difference on benchmarks (as expected because these methods should be inlined anyway), so merging without review. |
Member
Author
Merge activity
|
…remove unnecessary `matches!` (#10013) Small refactor. Fieldless enums are `Copy`, so it's pointless passing references to them (`&self`) into methods. Pass `self` instead. Additionally, replace `matches!` with `==` where possible, for shorter code and faster compilation.
graphite-app
bot
force-pushed
the
03-22-refactor_ast_methods_for_fieldless_enums_take_self_not_self_remove_unnecessary_matches_
branch
from
04c5362 to
a2b03d3
Compare
graphite-app
bot
deleted the
03-22-refactor_ast_methods_for_fieldless_enums_take_self_not_self_remove_unnecessary_matches_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor. Fieldless enums are
Copy, so it's pointless passing references to them (&self) into methods. Passselfinstead.Additionally, replace
matches!with==where possible, for shorter code and faster compilation.