fix(ast/estree): Fix ObjectProperty node
#10018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10018 will not alter performanceComparing Summary
|
therewillbecode
force-pushed
the
fix/object-property-ts-estree
branch
from
e09b6b4 to
2e16597
Compare
therewillbecode
changed the title
ObjectPattern nodeObjectProperty node
therewillbecode
force-pushed
the
fix/object-property-ts-estree
branch
4 times, most recently
from
0952daf to
81d2ec3
Compare
therewillbecode
force-pushed
the
fix/object-property-ts-estree
branch
from
81d2ec3 to
7048451
Compare
overlookmotel
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align our AST's ESTree output with that of TS-ESLint's for the
ObjectPropertynode. Relates to #9705Add
optionalfield and set tofalsefo theObjectPropertywhen serializing to TS estree.