feat(napi/parser): auto download wasm binding on webcontainer #10049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Boshen
deleted the
03-26-feat_napi_parser_auto_download_wasm_binding_on_webcontainer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oxc-parser equivalent of rolldown/rolldown#3922
As discussed within Stackblitz and Rolldown team, stackblitz's package swap isn't as simple nor as perfect as I thought, so Rolldown went with auto downloading wasm binding during runtime. I suggest doing the same for
oxc-parser.TODO: I need to figure out how to patchbinding.jsduring build pipeline.TODO: Let nuxt folks know if this is released.
This is yet again only testable with the actual release, so trial-and-error expected 😄
(At least, I tested running webcontainer-fallback.js directly on stackblitz https://stackblitz.com/edit/stackblitz-starters-yvuqgxo6?file=webcontainer-fallback.js)