Skip to content

perf(linter): inline PRE_DEFINE_VAR and use array format #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 27, 2025
Merged

perf(linter): inline PRE_DEFINE_VAR and use array format #10079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/oxc_linter/src/globals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
use phf::{Map, phf_map, phf_set};

pub const PRE_DEFINE_VAR: Map<&'static str, bool> = phf_map! {
"undefined" => false,
"Infinity" => false,
"NaN" => false,
"eval" => false,
"arguments" => false,
};
use phf::phf_set;

pub const GLOBAL_OBJECT_NAMES: phf::Set<&'static str> = phf_set! {
"global",
Expand Down
6 changes: 4 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_syntax::symbol::SymbolId;

use crate::{context::LintContext, globals::PRE_DEFINE_VAR, rule::Rule};
use crate::{context::LintContext, rule::Rule};

const PRE_DEFINE_VAR: [&str; 5] = ["undefined", "Infinity", "NaN", "eval", "arguments"];

fn no_shadow_restricted_names_diagnostic(shadowed_name: &str, span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Shadowing of global properties such as 'undefined' is not allowed.")
Expand Down Expand Up @@ -79,7 +81,7 @@ impl Rule for NoShadowRestrictedNames {
fn run_on_symbol(&self, symbol_id: SymbolId, ctx: &LintContext<'_>) {
let name = ctx.scoping().symbol_name(symbol_id);

if !PRE_DEFINE_VAR.contains_key(name) {
if !PRE_DEFINE_VAR.contains(&name) {
return;
}

Expand Down