Skip to content

Conversation

@ulrichstark
Copy link
Contributor

@ulrichstark ulrichstark commented Mar 28, 2025

Checks for the override and readonly modifier were missing before.

This PR is the result of splitting #10081 into smaller PRs.

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Mar 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10096 will not alter performance

Comparing ulrichstark:use-formalparameter-hasmodifier-in-semantic (987c423) with main (d82dff9)

Summary

✅ 36 untouched benchmarks

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I am going to merge it later. Because there is a huge stack that is going to merge, and it probably will conflict with this PR.

@ulrichstark ulrichstark force-pushed the use-formalparameter-hasmodifier-in-semantic branch from f90c393 to 987c423 Compare March 30, 2025 09:19
@ulrichstark
Copy link
Contributor Author

I rebased onto main to fix the merge conflicts.

@ulrichstark ulrichstark requested a review from Dunqing March 30, 2025 09:30
@Boshen Boshen merged commit bcd9a03 into oxc-project:main Mar 30, 2025
25 checks passed
@ulrichstark ulrichstark deleted the use-formalparameter-hasmodifier-in-semantic branch March 30, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants