Skip to content

refactor(linter): use FormalParameter::has_modifier to detect parameter properties #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dunqing merged 1 commit into from
Mar 28, 2025
Merged

refactor(linter): use FormalParameter::has_modifier to detect parameter properties #10097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(linter): use FormalParameter::has_modifier to detect parameter … 
…properties
  • Loading branch information
@ulrichstark
ulrichstark committed Mar 28, 2025
commit 0a97221cbb5620679b33a936f73bcf1b66d773e4
11 changes: 3 additions & 8 deletions crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ use oxc_ast::{
AstKind,
ast::{
Argument, BindingPattern, BindingPatternKind, BindingRestElement, CallExpression,
Expression, FormalParameters, FunctionBody, MethodDefinition, Statement, TSAccessibility,
Expression, FormalParameter, FormalParameters, FunctionBody, MethodDefinition, Statement,
TSAccessibility,
},
};
use oxc_diagnostics::OxcDiagnostic;
Expand Down Expand Up @@ -151,13 +152,7 @@ fn lint_empty_constructor<'a>(

// allow constructors with access modifiers since they actually declare
// class members
if constructor
.value
.params
.items
.iter()
.any(|param| param.accessibility.is_some() || param.readonly)
{
if constructor.value.params.items.iter().any(FormalParameter::has_modifier) {
return;
}

Expand Down
14 changes: 2 additions & 12 deletions crates/oxc_linter/src/rules/typescript/no_unnecessary_parameter_property_assignment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,8 @@ impl Rule for NoUnnecessaryParameterPropertyAssignment {
return;
}

let parameter_properties: Vec<_> = method
.value
.params
.items
.iter()
.filter(|param| {
// TypeScript offers special syntax for turning a constructor parameter into a class property with the same name and value.
// These are called parameter properties and are created by prefixing a constructor argument with one of the visibility modifiers public, private, protected, or readonly
// https://www.typescriptlang.org/docs/handbook/2/classes.html#parameter-properties
param.accessibility.is_some() || param.readonly
})
.collect();
let parameter_properties: Vec<_> =
method.value.params.items.iter().filter(|param| param.has_modifier()).collect();

if parameter_properties.is_empty() {
return;
Expand Down