Skip to content

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Apr 1, 2025

Create new TsValue struct and use in new exportKind field on the ExportDefaultDeclaration node.

Align our AST's ESTree output with that of TS-ESLint's for the ExportDefaultDeclaration node. Relates to #9705

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10165 will create unknown performance changes

Comparing therewillbecode:fix/export-default-declaration (64bb70a) with main (498b479)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.7 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.4 µs N/A
🆕 formatter[typescript.js] N/A 7.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.2 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.4 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.2 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 166.2 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 293.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@therewillbecode therewillbecode force-pushed the fix/export-default-declaration branch from 8fb82e9 to 79ca3b6 Compare April 2, 2025 07:35
@overlookmotel overlookmotel force-pushed the fix/export-default-declaration branch from 79ca3b6 to 64bb70a Compare April 2, 2025 12:21
@overlookmotel overlookmotel merged commit 34d5c00 into oxc-project:main Apr 2, 2025
25 checks passed
@therewillbecode therewillbecode deleted the fix/export-default-declaration branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants