Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 2, 2025

Small optimization. Check 4 bytes are all ASCII using a faster method.

Copy link
Member Author

overlookmotel commented Apr 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Apr 2, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2025 10:57
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Instrumentation Performance Report

Merging #10183 will create unknown performance changes

Comparing 04-02-perf_ast_estree_faster_checking_if_bytes_are_ascii (b5f8e38) with 04-02-fix_parser_store_lone_surrogates_in_templateelementvalue_as_escape_sequence (27768a5)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.5 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.5 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.7 µs N/A
🆕 formatter[typescript.js] N/A 7.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.5 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.3 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 166.2 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 293.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 04-02-fix_parser_store_lone_surrogates_in_templateelementvalue_as_escape_sequence branch from 2c70b2c to 3bca1f2 Compare April 2, 2025 11:24
@overlookmotel overlookmotel force-pushed the 04-02-perf_ast_estree_faster_checking_if_bytes_are_ascii branch from 079af9f to 1574e71 Compare April 2, 2025 11:24
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
Copy link
Member

Boshen commented Apr 2, 2025

Merge activity

Small optimization. Check 4 bytes are all ASCII using a faster method.
@graphite-app graphite-app bot force-pushed the 04-02-fix_parser_store_lone_surrogates_in_templateelementvalue_as_escape_sequence branch from 3bca1f2 to 27768a5 Compare April 2, 2025 12:59
@graphite-app graphite-app bot force-pushed the 04-02-perf_ast_estree_faster_checking_if_bytes_are_ascii branch from 1574e71 to b5f8e38 Compare April 2, 2025 13:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
Base automatically changed from 04-02-fix_parser_store_lone_surrogates_in_templateelementvalue_as_escape_sequence to main April 2, 2025 13:15
@graphite-app graphite-app bot merged commit b5f8e38 into main Apr 2, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-02-perf_ast_estree_faster_checking_if_bytes_are_ascii branch April 2, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants