-
-
Notifications
You must be signed in to change notification settings - Fork 781
refactor(ast/estree): alter Program start span with converter
#10195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast/estree): alter Program start span with converter
#10195
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
9979c1a to
e4d8baf
Compare
CodSpeed Instrumentation Performance ReportMerging #10195 will degrade performances by 4.8%Comparing Summary
Benchmarks breakdown
|
|
Does not alter serialized output, so merging without review. cc @therewillbecode FYI. |
Merge activity
|
Nice one! |
#10134 fixed the start span of `Program` in TS AST to align with TS-ESLint. Change the method this is achieved by - use a custom converter instead of mutating the AST in `to_estree_ts_json` and `to_pretty_estree_ts_json`. This method is more convoluted, but I think it's preferable if serialization does not have side effect of mutating the AST.
e4d8baf to
b662df4
Compare

#10134 fixed the start span of
Programin TS AST to align with TS-ESLint.Change the method this is achieved by - use a custom converter instead of mutating the AST in
to_estree_ts_jsonandto_pretty_estree_ts_json. This method is more convoluted, but I think it's preferable if serialization does not have side effect of mutating the AST.