refactor(ast)!: remove JSXOpeningElement::self_closing field
#10275
+121
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
CodSpeed Instrumentation Performance ReportMerging #10275 will not alter performanceComparing Summary
|
Member
Author
|
+1% improvement on |
Dunqing
approved these changes
Apr 7, 2025
Member
Author
Merge activity
|
Remove `self_closing` field from `JSXOpeningElement`. Whether the tag is self-closing can be determined by whether the `JSXElement` has a `closing_element` or not. This is advantageous for 2 reasons: 1. Reduce size of `JSXOpeningElement` by 8 bytes. 2. Make it impossible for `self_closing` and `closing_element` fields to get out of sync. Only one source of truth.
graphite-app
bot
force-pushed
the
04-06-refactor_ast_remove_jsxopeningelement_self_closing_field
branch
from
ce89055 to
a26fd34
Compare
graphite-app
bot
deleted the
04-06-refactor_ast_remove_jsxopeningelement_self_closing_field
branch
This was referenced Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
self_closingfield fromJSXOpeningElement. Whether the tag is self-closing can be determined by whether theJSXElementhas aclosing_elementor not.This is advantageous for 2 reasons:
JSXOpeningElementby 8 bytes.self_closingandclosing_elementfields to get out of sync. Only one source of truth.