-
-
Notifications
You must be signed in to change notification settings - Fork 780
refactor(allocator/vec): re-order methods #11080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
05-16-refactor_allocator_vec_re-order_methods
May 17, 2025
Merged
refactor(allocator/vec): re-order methods #11080
graphite-app
merged 1 commit into
main
from
05-16-refactor_allocator_vec_re-order_methods
May 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
Merged
Member
Author
fd40600 to
4aa658d
Compare
CodSpeed Instrumentation Performance ReportMerging #11080 will not alter performanceComparing Summary
|
Dunqing
approved these changes
May 16, 2025
This was referenced May 16, 2025
Member
Author
Merge activity
|
b239cb0 to
6a14896
Compare
4aa658d to
565bde0
Compare
6a14896 to
cfad6c4
Compare
565bde0 to
d12d30f
Compare
Pure refactor. Move simple getter / setter methods `len`, `set_len`, `capacity`, and `bump` towards the top of `impl`, after the constructor methods. I find it clearer to have these simple methods in an easy-to-find place. Does not change any code, just moves it.
cfad6c4 to
a6057c7
Compare
d12d30f to
aa76a16
Compare
Base automatically changed from
05-16-perf_allocator_vec_remove_setlenondrop_
to
main
May 17, 2025 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Pure refactor. Move simple getter / setter methods
len,set_len,capacity, andbumptowards the top ofimpl, after the constructor methods.I find it clearer to have these simple methods in an easy-to-find place.
Does not change any code, just moves it.