Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 16, 2025

Pure refactor. Move simple getter / setter methods len, set_len, capacity, and bump towards the top of impl, after the constructor methods.

I find it clearer to have these simple methods in an easy-to-find place.

Does not change any code, just moves it.

Copy link
Member Author

overlookmotel commented May 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 16, 2025 13:40
@overlookmotel overlookmotel force-pushed the 05-16-refactor_allocator_vec_re-order_methods branch from fd40600 to 4aa658d Compare May 16, 2025 13:42
@codspeed-hq
Copy link

codspeed-hq bot commented May 16, 2025

CodSpeed Instrumentation Performance Report

Merging #11080 will not alter performance

Comparing 05-16-refactor_allocator_vec_re-order_methods (aa76a16) with main (f0b76e8)

Summary

✅ 36 untouched benchmarks

Copy link
Member Author

overlookmotel commented May 17, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-16-perf_allocator_vec_remove_setlenondrop_ branch 2 times, most recently from b239cb0 to 6a14896 Compare May 17, 2025 10:25
@graphite-app graphite-app bot force-pushed the 05-16-refactor_allocator_vec_re-order_methods branch from 4aa658d to 565bde0 Compare May 17, 2025 10:25
@overlookmotel overlookmotel force-pushed the 05-16-perf_allocator_vec_remove_setlenondrop_ branch from 6a14896 to cfad6c4 Compare May 17, 2025 12:05
@overlookmotel overlookmotel force-pushed the 05-16-refactor_allocator_vec_re-order_methods branch from 565bde0 to d12d30f Compare May 17, 2025 12:05
Pure refactor. Move simple getter / setter methods `len`, `set_len`, `capacity`, and `bump` towards the top of `impl`, after the constructor methods.

I find it clearer to have these simple methods in an easy-to-find place.

Does not change any code, just moves it.
@graphite-app graphite-app bot force-pushed the 05-16-perf_allocator_vec_remove_setlenondrop_ branch from cfad6c4 to a6057c7 Compare May 17, 2025 14:52
@graphite-app graphite-app bot force-pushed the 05-16-refactor_allocator_vec_re-order_methods branch from d12d30f to aa76a16 Compare May 17, 2025 14:53
Base automatically changed from 05-16-perf_allocator_vec_remove_setlenondrop_ to main May 17, 2025 14:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 17, 2025
@graphite-app graphite-app bot merged commit aa76a16 into main May 17, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 05-16-refactor_allocator_vec_re-order_methods branch May 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants