Skip to content

refactor(allocator): use type alias for InnerVec #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
May 22, 2025
Merged

refactor(allocator): use type alias for InnerVec #11209

graphite-app merged 1 commit into from
May 22, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 21, 2025 •
edited
Loading

Follow-on after #11199. Pure refactor. In Vec, use a type alias for InnerVec, instead of specifying InnerVec<'a, T, Bump> in multiple places.

This makes the dependency on bumpalo::Bump be on just 1 line, which is tidier.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 21, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented May 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11209 will not alter performance

Comparing 05-21-refactor_allocator_use_type_alias_for_innervec_ (ddcf248) with main (86e753d)

Summary

✅ 38 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review May 21, 2025 08:59
@overlookmotel
Copy link
Member Author

overlookmotel commented May 22, 2025

Minor change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 22, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented May 22, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(allocator): use type alias for InnerVec (#11209)
ddcf248 
Follow-on after #11199. Pure refactor. In `Vec`, use a type alias for `InnerVec`, instead of specifying `InnerVec<'a, T, Bump>` in multiple places.

This makes the dependency on `bumpalo::Bump` be on just 1 line, which is tidier.
@graphite-app graphite-app bot force-pushed the 05-21-refactor_allocator_use_type_alias_for_innervec_ branch from 2d5d161 to ddcf248 Compare May 22, 2025 22:19
@graphite-app graphite-app bot merged commit ddcf248 into main May 22, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 22, 2025
@graphite-app graphite-app bot deleted the 05-21-refactor_allocator_use_type_alias_for_innervec_ branch May 22, 2025 22:26
@oxc-bot oxc-bot mentioned this pull request May 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel