Skip to content

feat(semantic): add current_scope_flags function in SemanticBuilder#1906

Merged
Boshen merged 1 commit intomainfrom
01-06-feat_semantic_add_current_scope_flags_property
Jan 6, 2024
Merged

feat(semantic): add current_scope_flags function in SemanticBuilder#1906
Boshen merged 1 commit intomainfrom
01-06-feat_semantic_add_current_scope_flags_property

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 6, 2024

No description provided.

@Dunqing
Copy link
Member Author

Dunqing commented Jan 6, 2024

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to deny this change, keeping multiple states is error prone, you can add a function instead.

The performance impact should be negligible.

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add a fn current_scope_flags() instead.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2024

CodSpeed Performance Report

Merging #1906 will not alter performance

Comparing 01-06-feat_semantic_add_current_scope_flags_property (964604e) with main (24d209c)

Summary

✅ 14 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Jan 6, 2024

You may add a fn current_scope_flags() instead.

Sounds good

@Dunqing Dunqing force-pushed the 01-06-feat_semantic_add_current_scope_flags_property branch from 1953b68 to 964604e Compare January 6, 2024 04:43
@Dunqing Dunqing changed the title feat(semantic): add current_scope_flags property feat(semantic): add current_scope_flags function in SemanticBuilder Jan 6, 2024
Copy link
Member

Boshen commented Jan 6, 2024

Merge activity

  • Jan 5, 11:51 PM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Jan 5, 11:51 PM: @Boshen merged this pull request with Graphite.

@Boshen Boshen merged commit b0569bc into main Jan 6, 2024
@Boshen Boshen deleted the 01-06-feat_semantic_add_current_scope_flags_property branch January 6, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants