Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(linter): correct comment handling in no_useless_undefined rule
  • Loading branch information
cblh committed Jul 10, 2024
commit 928f276bcc6853bc23bd9fe24d8885615c0084ae
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/unicorn/no_useless_undefined.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,13 @@ impl Rule for NoUselessUndefined {
ctx.diagnostic_with_fix(
no_useless_undefined_diagnostic(undefined_literal.span),
|fixer| {
let delete_span = if let Some((_, comment)) = ctx
let delete_span = if let Some(comment) = ctx
.semantic()
.trivias()
.comments_range(ret_stmt.span.start..ret_stmt.span.end)
.last()
{
Span::new(comment.end + 2, undefined_literal.span.end)
Span::new(comment.span.end + 2, undefined_literal.span.end)
} else {
Span::new(ret_stmt.span().start + 6, undefined_literal.span.end)
};
Expand Down