Skip to content

Conversation

@jordan-boyer
Copy link
Contributor

@jordan-boyer jordan-boyer commented Jul 10, 2024

Here is my take on this rules.

I have some weird edge case that i did put on the weird_test_case if you guys wanted to take a look.

close: #3870

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 10, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #4159 will degrade performances by 4.48%

Comparing jordan-boyer:feat-add-no-useless-undefined-rule (468548e) with main (03ad1e3)

Summary

❌ 2 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jordan-boyer:feat-add-no-useless-undefined-rule Change
linter[cal.com.tsx] 742.1 ms 765.8 ms -3.09%
linter[checker.ts] 1.4 s 1.4 s -4.48%

@DonIsaac
Copy link
Contributor

Also, there's this PR here already: #4079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(linter): eslint-plugin-unicorn/no-useless-undefined

2 participants