Skip to content

perf(semantic): remove a branch from record_ast_node #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
overlookmotel wants to merge 3 commits into from
Closed

perf(semantic): remove a branch from record_ast_node #4273

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f14952
perf(semantic): remove a branch from `record_ast_node`
overlookmotel Jul 15, 2024
6adfb66
Dummy comment to re-run benchmark
overlookmotel Jul 15, 2024
019b4d3
Revert "Dummy comment to re-run benchmark"
overlookmotel Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "Dummy comment to re-run benchmark" 
This reverts commit 788269e.
  • Loading branch information
@overlookmotel @Boshen
overlookmotel authored and Boshen committed Jul 15, 2024
commit 019b4d36a745243fc49226f36abb7effa92facbc
1 change: 0 additions & 1 deletion crates/oxc_semantic/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ impl<'a> SemanticBuilder<'a> {
*record = self.current_node_id;
}
}
// Dummy comment to re-run benchmark. TODO Remove me.
}

pub fn current_scope_flags(&self) -> ScopeFlags {
Expand Down