Skip to content

Conversation

@github-actions
Copy link
Contributor

[0.21.0] - 2024-07-17

Features

Bug Fixes

Performance

Refactor

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Boshen
Copy link
Member

Boshen commented Jul 17, 2024

@Dunqing Can you test rolldown before making a release when you wake up?

@Dunqing
Copy link
Member

Dunqing commented Jul 17, 2024

@Dunqing Can you test rolldown before making a release when you wake up?

Yes, I can

@Boshen
Copy link
Member

Boshen commented Jul 17, 2024

Cool, click Merge without waiting for requirements to be met (bypass branch protections) + squash and merge once you're done.

@Dunqing
Copy link
Member

Dunqing commented Jul 18, 2024

In

https://github.com/rolldown-rs/rolldown/blob/main/crates/rolldown/tests/fixtures/rollup/catch-scope-shadowing/main.js#L20

import assert from 'assert';
var e = 'failed1',
  x = 'value';

(function () {
  try {
    // empty
  } catch (e) {
    var e = 'failed2';
  }

  assert.strictEqual(e, undefined);
  assert.strictEqual(x, undefined);
  x = 'failed3';
  return;

  try {
    not_reached();
  } catch (x) {
    var x = 'failed4';
  }
})();

assert.strictEqual(x, 'value');

Out

import { default as assert } from "assert";

//#region main.js
var e = "failed1", x = "value";
(function() {
	try {} catch (e$1) {
		var e$1 = "failed2";
	}
	assert.strictEqual(e, undefined);
	assert.strictEqual(x$1, undefined);
	x$1 = "failed3";
	return;
	var x$1;
})();
assert.strictEqual(x, "value");

//#endregion

Expected

import { default as assert } from "assert";

//#region main.js
var e = 'failed1', x = 'value';
(function() {
	try {} catch (e$1) {
		var e$1 = 'failed2';
	}
	assert.strictEqual(e$1, undefined);
	assert.strictEqual(x$1, undefined);
	x$1 = 'failed3';
	return;
	try {
		not_reached();
	} catch (x$1) {
		var x$1 = 'failed4';
	}
})();
assert.strictEqual(x, 'value');

This test failed because the scope changed. I am working to figure it out.

@Dunqing
Copy link
Member

Dunqing commented Jul 18, 2024

Closing this. See #4338

@Dunqing Dunqing closed this Jul 18, 2024
@Dunqing
Copy link
Member

Dunqing commented Jul 18, 2024

Do we have a command to update the branch instead of creating another PR?

@Boshen
Copy link
Member

Boshen commented Jul 18, 2024

Do we have a command to update the branch instead of creating another PR?

Nope, but you can update manually.

@Boshen Boshen deleted the release/crates-1721221767 branch September 11, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants