Skip to content

test(semantic): add more test cases for symbol references #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 24, 2024
Merged

test(semantic): add more test cases for symbol references #4429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(semantic): add more test cases for symbol references (#4429)
  • Loading branch information
@DonIsaac
DonIsaac committed Jul 24, 2024
commit 4b274a8e6feaa9756924da5fb277489c6f6b24a6
28 changes: 27 additions & 1 deletion crates/oxc_semantic/tests/integration/symbols.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use oxc_semantic::SymbolFlags;
use oxc_semantic::{Reference, SymbolFlags};

use crate::util::SemanticTester;

Expand Down Expand Up @@ -55,6 +55,18 @@ fn test_var_read_write() {
.has_number_of_writes(1)
.test();

SemanticTester::js("let x = 0; let foo = (0, x++)")
.has_some_symbol("x")
.has_number_of_reads(1)
.has_number_of_writes(1)
.test();

SemanticTester::js("let x = 0; x++")
.has_some_symbol("x")
.has_number_of_reads(0)
.has_number_of_writes(1)
.test();

SemanticTester::js("let a; let b = 1 + (0, ((a)));")
.has_some_symbol("a")
.has_number_of_reads(1)
Expand Down Expand Up @@ -96,6 +108,20 @@ fn test_types_simple() {
.contains_flags(SymbolFlags::TypeAlias)
.has_number_of_references(1)
.test();

SemanticTester::ts("function foo<T>(): T { }")
.has_some_symbol("T")
.contains_flags(SymbolFlags::TypeParameter)
.has_number_of_references(1)
.has_number_of_references_where(1, oxc_semantic::Reference::is_type)
.test();

SemanticTester::ts("function foo<T>(a: T): void {}")
.has_some_symbol("T")
.contains_flags(SymbolFlags::TypeParameter)
.has_number_of_references(1)
.has_number_of_references_where(1, Reference::is_type)
.test();
}

#[test]
Expand Down