Skip to content

refactor(semantic): re-order SymbolTable fields #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 25, 2024
Merged

refactor(semantic): re-order SymbolTable fields #4459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(semantic): re-order SymbolTable fields (#4459) 
Group the fields which are SoA indexed by `ScopeId` together.
  • Loading branch information
@overlookmotel
overlookmotel committed Jul 25, 2024
commit a49f4915de38a57f9da4488b4d38b592ee15619f
3 changes: 2 additions & 1 deletion crates/oxc_semantic/src/symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ pub struct SymbolTable {
/// Pointer to the AST Node where this symbol is declared
pub declarations: IndexVec<SymbolId, AstNodeId>,
pub resolved_references: IndexVec<SymbolId, Vec<ReferenceId>>,
pub references: IndexVec<ReferenceId, Reference>,
pub redeclare_variables: IndexVec<SymbolId, Vec<Span>>,

pub references: IndexVec<ReferenceId, Reference>,
}

impl SymbolTable {
Expand Down