Skip to content

ci: use deterministic allocator for benchmarks #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
overlookmotel wants to merge 6 commits into from
Closed

ci: use deterministic allocator for benchmarks #4483

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7f0f2a
ci: use deterministic allocator for benchmarks
overlookmotel Jul 26, 2024
ff73aef
Fix clippy
overlookmotel Jul 26, 2024
7f32947
Align arena buffer
overlookmotel Jul 26, 2024
b85ec1c
Initialize arena buffer with 1s
overlookmotel Jul 27, 2024
80a677e
Revert "Initialize arena buffer with 1s"
overlookmotel Jul 29, 2024
70e6c9c
Ensure arena alignment
overlookmotel Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Align arena buffer
  • Loading branch information
@overlookmotel
overlookmotel committed Jul 29, 2024
commit 7f3294762c26b1bbca55ded430422610f70b6d1a
7 changes: 5 additions & 2 deletions tasks/benchmark/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,14 @@ use talc::{ClaimOnOom, Span, Talc, Talck};
/// 1 GiB memory limit
const ARENA_SIZE: usize = 0x4000_0000;

static mut ARENA: [u8; ARENA_SIZE] = [0; ARENA_SIZE];
#[repr(align(64))]
struct AlignedBytes([u8; ARENA_SIZE]);

static mut ARENA: AlignedBytes = AlignedBytes([0; ARENA_SIZE]);

#[global_allocator]
static GLOBAL: Talck<spin::Mutex<()>, ClaimOnOom> = Talc::new({
// SAFETY: Copied from `talc`'s docs https://github.com/SFBdragon/talc#setup
unsafe { ClaimOnOom::new(Span::from_const_array(core::ptr::addr_of!(ARENA))) }
unsafe { ClaimOnOom::new(Span::from_const_array(core::ptr::addr_of!(ARENA.0))) }
})
.lock();