fix(benchmark): sourcemap benchmark properly test ConcatSourceMapBuilder

[overlookmotel]

Make 2 changes to sourcemap benchmark:

1. Move counting line breaks in output text to outside of the measured loop. This operation is reasonably expensive, and isn't part of what we're trying to measure.

2. It looks like benchmark is trying to measure concatenating 2 source maps, but for i in 0..1 was actually only concatenating 1.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• fix(benchmark): sourcemap benchmark properly test ConcatSourceMapBuilder #4528 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

I'm pretty sure (2) was a mistake, but I don't know for sure what this benchmark is aiming to measure. Can anyone confirm?

[codspeed-hq]

CodSpeed Performance Report

Merging #4528 will degrade performances by 28.58%

_{Comparing 07-29-fix_benchmark_sourcemap_benchmark_properly_test_concatsourcemapbuilder_ (affd768) with main (d8c2a83)}

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	07-29-fix_benchmark_sourcemap_benchmark_properly_test_concatsourcemapbuilder_	Change
❌	sourcemap[cal.com.tsx]	54.7 ms	76.7 ms	-28.58%

[graphite-app]

Merge activity

• Jul 29, 7:14 AM EDT: Brooooooklyn added this pull request to the Graphite merge queue.
• Jul 29, 7:17 AM EDT: Brooooooklyn merged this pull request with the Graphite merge queue.