Skip to content

Conversation

@DonIsaac
Copy link
Contributor

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review July 31, 2024 22:25
Copy link
Contributor Author

DonIsaac commented Jul 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac force-pushed the don/07-31-refactor_overhaul_napi_transformer_package branch from 6aa4d57 to b736467 Compare July 31, 2024 22:26
@DonIsaac DonIsaac force-pushed the don/07-31-feat_napi/transform_add_minify_option branch from 0b6707d to f23b047 Compare July 31, 2024 22:26
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2024

CodSpeed Performance Report

Merging #4593 will not alter performance

Comparing don/07-31-feat_napi/transform_add_minify_option (2f253fb) with main (9b51e04)

Summary

✅ 32 untouched benchmarks

@Boshen Boshen self-assigned this Aug 1, 2024
@DonIsaac DonIsaac force-pushed the don/07-31-refactor_overhaul_napi_transformer_package branch from b736467 to 554beb7 Compare August 5, 2024 01:37
@DonIsaac DonIsaac force-pushed the don/07-31-feat_napi/transform_add_minify_option branch from f23b047 to 71b0e97 Compare August 5, 2024 01:37
@DonIsaac DonIsaac force-pushed the don/07-31-refactor_overhaul_napi_transformer_package branch from 554beb7 to 18cb65a Compare August 5, 2024 15:34
@DonIsaac DonIsaac force-pushed the don/07-31-feat_napi/transform_add_minify_option branch from 71b0e97 to f7128cb Compare August 5, 2024 15:34
@DonIsaac DonIsaac force-pushed the don/07-31-refactor_overhaul_napi_transformer_package branch from 18cb65a to a7bac91 Compare August 5, 2024 20:03
@DonIsaac DonIsaac force-pushed the don/07-31-feat_napi/transform_add_minify_option branch from f7128cb to 1da5f30 Compare August 5, 2024 20:03
@Boshen Boshen force-pushed the don/07-31-refactor_overhaul_napi_transformer_package branch from a7bac91 to 9b51e04 Compare August 6, 2024 01:14
@Boshen Boshen changed the base branch from don/07-31-refactor_overhaul_napi_transformer_package to main August 6, 2024 01:19
@Boshen Boshen force-pushed the don/07-31-feat_napi/transform_add_minify_option branch from 1da5f30 to 2f253fb Compare August 6, 2024 01:19
@Boshen
Copy link
Member

Boshen commented Aug 11, 2024

This feels like a confusing API. Shall we close this until user requirement comes up?

@DonIsaac
Copy link
Contributor Author

Sure, I can keep using my original code in oxc-jest for the time being

@Boshen Boshen closed this Aug 11, 2024
@Boshen Boshen deleted the don/07-31-feat_napi/transform_add_minify_option branch August 11, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants