Skip to content

refactor(semantic): simplify setting scope flags #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dunqing merged 1 commit into from
Aug 5, 2024
Merged

refactor(semantic): simplify setting scope flags #4674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(semantic): simplify setting scope flags
  • Loading branch information
@overlookmotel
overlookmotel committed Aug 5, 2024
commit ef771a8e647bfa7e96497bb49bce83abdfd79735
10 changes: 2 additions & 8 deletions crates/oxc_semantic/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,15 +510,9 @@ impl<'a> SemanticBuilder<'a> {

impl<'a> Visit<'a> for SemanticBuilder<'a> {
// NB: Not called for `Program`
fn enter_scope(&mut self, mut flags: ScopeFlags, scope_id: &Cell<Option<ScopeId>>) {
fn enter_scope(&mut self, flags: ScopeFlags, scope_id: &Cell<Option<ScopeId>>) {
let parent_scope_id = self.current_scope_id;

if !flags.is_strict_mode() && self.current_node_flags.has_class() {
// NOTE A class definition is always strict mode code.
flags |= ScopeFlags::StrictMode;
};
flags = self.scope.get_new_scope_flags(flags, parent_scope_id);

let flags = self.scope.get_new_scope_flags(flags, parent_scope_id);
self.current_scope_id = self.scope.add_scope(parent_scope_id, self.current_node_id, flags);
scope_id.set(Some(self.current_scope_id));

Expand Down