Skip to content

fix(codegen): print raw if value is number is Infinity #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 6, 2024
Merged

fix(codegen): print raw if value is number is Infinity #4676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(codegen): print raw if value is number is Infinity (#4676)
  • Loading branch information
@Boshen
Boshen committed Aug 6, 2024
commit 4a5695416de38bcadf1f8fa1516eae2c68cc8487
3 changes: 1 addition & 2 deletions crates/oxc_codegen/examples/codegen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ fn main() -> std::io::Result<()> {
let ret = Parser::new(&allocator, &printed, source_type).parse();
if !ret.errors.is_empty() {
for error in ret.errors {
let error = error.with_source_code(source_text.to_string());
println!("{error:?}");
println!("{:?}", error.with_source_code(printed.to_string()));
}
return Ok(());
}
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for NumericLiteral<'a> {
let bytes = result.as_str();
p.print_str(bytes);
need_space_before_dot(bytes, p);
} else if self.value == f64::INFINITY {
} else if self.value == f64::INFINITY && self.raw.is_empty() {
p.print_str("Infinity");
need_space_before_dot("Infinity", p);
} else {
Expand Down
3 changes: 1 addition & 2 deletions tasks/coverage/codegen_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ commit: d8086f14

codegen_typescript Summary:
AST Parsed : 6456/6456 (100.00%)
Positive Passed: 6455/6456 (99.98%)
Normal failed: "compiler/deferredConditionalTypes2.ts"
Positive Passed: 6456/6456 (100.00%)