Skip to content

feat(linter): add fixer for eslint/for-direction #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonIsaac merged 5 commits into from
Aug 7, 2024
+45 −4
Merged

feat(linter): add fixer for eslint/for-direction #4679

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1eb752a
feat(linter): add fixer for eslint/for-direction
heygsc Aug 6, 2024
0a7ce67
fix typo
heygsc Aug 6, 2024
e35a125
add variables of different lengths
heygsc Aug 6, 2024
0c1a97a
refactor: logical order
heygsc Aug 7, 2024
6ff1d90
Merge branch 'main' into fixer-for-direction
heygsc Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions crates/oxc_linter/src/rules/eslint/for_direction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use oxc_ast::{
};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{GetSpan, Span};
use oxc_syntax::operator::{AssignmentOperator, BinaryOperator, UnaryOperator, UpdateOperator};

use crate::{context::LintContext, rule::Rule, AstNode};
Expand Down Expand Up @@ -38,7 +38,8 @@ declare_oxc_lint!(
/// for (var = 10; i >= 0; i++) {}
/// ```
ForDirection,
correctness
correctness,
dangerous_fix
);

impl Rule for ForDirection {
Expand Down Expand Up @@ -66,7 +67,35 @@ impl Rule for ForDirection {
let update_direction = get_update_direction(update, counter);
if update_direction == wrong_direction {
let update_span = get_update_span(update);
ctx.diagnostic(for_direction_diagnostic(test.span, update_span));
ctx.diagnostic_with_dangerous_fix(
for_direction_diagnostic(test.span, update_span),
|fixer| {
let mut start: u32 = 0;
if let Expression::UpdateExpression(update) = update {
start = update.argument.span().end;
} else if let Expression::AssignmentExpression(update) = update {
start = update.left.span().end;
}
let end = start + 2;
let span = Span::new(start, end);
let mut new_operator_str = "";
if let Expression::UpdateExpression(update) = update {
if let UpdateOperator::Increment = update.operator {
new_operator_str = "--";
} else if let UpdateOperator::Decrement = update.operator {
new_operator_str = "++";
}
} else if let Expression::AssignmentExpression(update) = update {
if let AssignmentOperator::Addition = update.operator {
new_operator_str = "-=";
} else if let AssignmentOperator::Subtraction = update.operator
{
new_operator_str = "+=";
}
}
fixer.replace(span, new_operator_str)
},
);
}
}
}
Expand Down Expand Up @@ -224,5 +253,17 @@ fn test() {
("for(var i = 0; 10 > i; i-=1){}", None),
];

Tester::new(ForDirection::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("for(var i = 0; i < 10; i--){}", "for(var i = 0; i < 10; i++){}", None),
("for(var i = 10; i > 0; i++){}", "for(var i = 10; i > 0; i--){}", None),
("for(var i = 0; i < 10; i-=1){}", "for(var i = 0; i < 10; i+=1){}", None),
("for(var i = 10; i > 0; i+=1){}", "for(var i = 10; i > 0; i-=1){}", None),
("for(var i = 0; i < 10; i+=-1){}", "for(var i = 0; i < 10; i-=-1){}", None),
("for(var i = 10; i > 0; i-=-1){}", "for(var i = 10; i > 0; i+=-1){}", None),
// variables of different lengths
("for(var ii = 0; ii < 10; ii--){}", "for(var ii = 0; ii < 10; ii++){}", None),
("for(var ii = 10; ii > 0; ii+=1){}", "for(var ii = 10; ii > 0; ii-=1){}", None),
];

Tester::new(ForDirection::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}