perf(linter): add Set

[DonIsaac]

Many rules store a Vec<String> in their configs for things like ignore lists or JSX tags that should be checked. They are created once (in from_configuration) and mostly used for Vec::contains. There are a few problems with this:

1. Strings are always heap-allocated. We should inline when possible, using CompactStr.
2. Vec::contains is O(n), and is usually used in a hot path.
3. Vec::contains requires an &T, meaning there are many cases when rules have an &str and need to allocate a new String just to pass it to contains. This is highly wasteful.
4. Many rules have duplicate logic for parsing a Vec<String> from a Value.

This PR adds Set<T>, which seeks to make this use case more performant. It's very simple ordered set of unique items backed by a Vec. Read the doc comments over the struct definition for a more in-depth rationale.

Improvements

1. Set<T> supports O(log(n)) containment checks at the cost of O(nlog(n)) initialization. This is fine since we create it once and read from it many times.
2. Set<T> where T: AsRef<str>> supports a contains_str method that is identical to contains but does not force consumers to allocate new strings
3. Set<CompactStr> implements TryFrom<Value>, which DRYs up rule config parsing. This trait is intentionally not implemented for Set<String> to nudge rules towards using CompactStr.

Following PRs will modify existing rules to use Set<CompactStr> over Vec<String>. Since most of these cases are within Jest and VITest rules, I don't expect improvements to appear on benchmarks (rules are skipped when non-applicable, and we have no benchmarks for Jest specs).

[DonIsaac]

• perf(linter): start using Set in lint rules #4707
• perf(linter): add Set #4697 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4697 will not alter performance

_{Comparing don/08-05-perf_linter_add_set (21086ad) with main (06efae6)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Boshen]

I think we should avoid our own data structures for the sake of maintainability and discoverability.

This will make it difficult for contributors to learn - remember most contributors come from JavaScript, we should lower the barrier.

As for optimization, perhaps replacing String for CompactStr is more than enough. Hot spots can also use smallvec. But reading from the heap where the vec is small won't be a performance hot spot because they'll likely live in a nearby cache.