Skip to content

feat(transformer): async-to-generator plugin. #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dunqing merged 26 commits into from
Oct 14, 2024
Merged

feat(transformer): async-to-generator plugin. #5590

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
9f003bb
feat: to async generator.
7086cmd Sep 7, 2024
1b82340
chore: lint.
7086cmd Sep 7, 2024
53c57cf
fix: avoid iteration.
7086cmd Sep 7, 2024
2629c3a
chore: lint.
7086cmd Sep 7, 2024
524b20a
chore: lint.
7086cmd Sep 7, 2024
9188d29
refactor: align esbuild does.
7086cmd Sep 22, 2024
6a8aebc
chore: format.
7086cmd Sep 22, 2024
d6572fd
chore: resolve tests.
7086cmd Sep 22, 2024
8a827cc
chore: remove file [ci skip]
7086cmd Sep 22, 2024
8dbf73b
perf: avoid cloning.
7086cmd Sep 23, 2024
11a4013
perf: avoid cloning in expression.
7086cmd Sep 24, 2024
e39f2c6
chore: format.
7086cmd Sep 24, 2024
facd2e2
refactor: align with babel without cloning.
7086cmd Sep 24, 2024
2f736a4
chore: format.
7086cmd Sep 24, 2024
08ddcc4
fix
7086cmd Sep 24, 2024
c3f85dc
chore: add tests, fix: arrow expression.
7086cmd Sep 24, 2024
d29ea21
chore: format.
7086cmd Sep 24, 2024
071c28f
refactor: remove `ctx`.
7086cmd Sep 24, 2024
e7feb66
chore: align with latest.
7086cmd Sep 28, 2024
ca74e6a
chore: format.
7086cmd Sep 28, 2024
e83cf6c
fix: should pass the arguments to generator function.
7086cmd Sep 28, 2024
f4d3fd2
chore: update snapshots.
7086cmd Sep 28, 2024
b194592
perf: reduce taking.
7086cmd Sep 28, 2024
28b3074
refactor: use ast builder.
7086cmd Sep 30, 2024
4ee2faf
chore: docs.
7086cmd Sep 30, 2024
58863b5
Merge remote-tracking branch 'origin/main' into feat/transform-async-…
Dunqing Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perf: reduce taking.
  • Loading branch information
@7086cmd
7086cmd committed Sep 30, 2024
commit b194592f4a2fd97bc0897f7730e90b607128355d
47 changes: 1 addition & 46 deletions crates/oxc_transformer/src/es2017/async_to_generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,36 +91,11 @@ impl AsyncToGenerator {
let parameters =
ctx.ast.vec1(ctx.ast.argument_expression(ctx.ast.expression_from_function(target)));
let call = ctx.ast.expression_call(SPAN, callee, NONE, parameters, false);
let call = ctx.ast.expression_member(ctx.ast.member_expression_static(
SPAN,
call,
ctx.ast.identifier_name(SPAN, "apply"),
false,
));
let call = ctx.ast.expression_call(
SPAN,
call,
NONE,
{
let mut items = ctx.ast.vec();
items.push(ctx.ast.argument_expression(ctx.ast.expression_this(SPAN)));
items.push(ctx.ast.argument_expression(
ctx.ast.expression_identifier_reference(SPAN, "arguments"),
));
items
},
false,
);
let returns = ctx.ast.return_statement(SPAN, Some(call));
let body = Statement::ReturnStatement(ctx.ast.alloc(returns));
let body = ctx.ast.function_body(SPAN, ctx.ast.vec(), ctx.ast.vec1(body));
let body = ctx.ast.alloc(body);
let params = ctx.ast.formal_parameters(
SPAN,
func.params.kind,
ctx.ast.move_vec(&mut func.params.items),
func.params.rest.take(),
);
let params = ctx.ast.formal_parameters(SPAN, func.params.kind, ctx.ast.vec(), NONE);
ctx.ast.function(
FunctionType::FunctionExpression,
SPAN,
Expand Down Expand Up @@ -242,26 +217,6 @@ impl<'a> Traverse<'a> for AsyncToGenerator {
let parameters =
ctx.ast.vec1(ctx.ast.argument_expression(ctx.ast.expression_from_function(target)));
let call = ctx.ast.expression_call(SPAN, callee, NONE, parameters, false);
let call = ctx.ast.expression_member(ctx.ast.member_expression_static(
SPAN,
call,
ctx.ast.identifier_name(SPAN, "apply"),
false,
));
let call = ctx.ast.expression_call(
SPAN,
call,
NONE,
{
let mut items = ctx.ast.vec();
items.push(ctx.ast.argument_expression(ctx.ast.expression_this(SPAN)));
items.push(ctx.ast.argument_expression(
ctx.ast.expression_identifier_reference(SPAN, "arguments"),
));
items
},
false,
);
let body = ctx.ast.function_body(
SPAN,
ctx.ast.vec(),
Expand Down